Add timeout option

[tomconnell-wf]

Motivation

I hope to make the timeout on InfoReceiver handshake configurable. sockjs/sockjs-client#594

When that happens, the wrapper will need its api updated to actually pass in the timeout option to SockJS.

Changes

Add the timeout to the SockJsOptions

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

• Tests were updated and provide good coverage of the changeset and other affected code
• Manual testing was performed if needed
  • Steps from PR author:
  • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

• A Frontend Architecture member has reviewed these changes
• There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
• For release PRs - Version metadata in Rosie comment is correct

[tomconnell-wf]

This can't actually merge, since I manually made changes to sockjs.js, but the code changes are there because I needed to be able to test with https://github.com/Workiva/doc_plat_client/pull/30069

[aviary3-wk]

Security Insights

The items listed below may not capture all security relevant changes. Before providing a security review, be sure to review the entire PR for security impact.

(1) Security relevant changes were detected

Watched file lib/sockjs.js modified

Action Items

• Obtain a security review; reviewer should pay special attention to insights listed above
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[patkujawa-wf]

If sockJS's internally calculated
/// timeout is higher, that will be used instead.

😕 if true, shouldn't this conditional be < ? But maybe also set a lower limit?

[patkujawa-wf]

Ah, it's min timeout!

[tomconnell-wf]

Oh, whoops, I must have had that slip through the cracks somewhere. I'll see what the sockjs maintainer says. (I don't know if they will want this or that)

[patkujawa-wf]

Looks like dart format needed too

[evanweible-wf]

LGTM pending that one question about the timeout and the upstream PR.

[tomconnell-wf]

Couldn't get sockjs to look at my PR. sockjs/sockjs-client#594