Open
Conversation
|
@a1exndr Did you test this on your lcoal version of lax? Does it work as intended? @chiaracapelli. @cwittweg and @skazama Can you approve the PR? |
Contributor
Author
|
@jpienaar13 Yes, I'm successfully working with it with the lax installation (Pax v6.10.1, Hax v2.5.0 and Lax v1.7.2) on dali. |
cwittweg
suggested changes
Oct 1, 2020
cwittweg
left a comment
cwittweg
left a comment
There was a problem hiding this comment.
I think we should move the parameter files to LAX or a central directory instead of having them in a personal directory (lines 301, 302).
cwittweg
approved these changes
Oct 1, 2020
cwittweg
left a comment
cwittweg
left a comment
There was a problem hiding this comment.
Ok, nevermind. This has also been done for other cuts. I have a feeling we should do this differently for XENONnT, but it seems to be the method of choice for XENON1T.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An updated version of the S2PatternLikelihood cut is proposed for the SR2 DEC analysis, based on the results presented in the following note:
https://xe1t-wiki.lngs.infn.it/doku.php?id=xenon:xenon1t:dec:s2patternlikelihoodsr2dec
The cut has been reviewed and approved by @skazama :
https://xe1t-wiki.lngs.infn.it/doku.php?id=xenon:xenon1t:wittweg:dec_extended_s2patternlikelihood_shingo_review