Skip to content

fix bug breaking PausableTypewriter when pause occurs at beginning of… #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
desplesda merged 1 commit into from
Dec 10, 2024
Merged

fix bug breaking PausableTypewriter when pause occurs at beginning of… #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Runtime/Views/Effects.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,6 @@ public static IEnumerator PausableTypewriter(TextMeshProUGUI text, float letters
// time for.
while (accumulator >= secondsPerLetter)
{
text.maxVisibleCharacters += 1;

// ok so the change needs to be that if at any point we hit the pause position
// we instead stop worrying about letters
// and instead we do a normal wait for the necessary duration
Expand All @@ -272,6 +270,8 @@ public static IEnumerator PausableTypewriter(TextMeshProUGUI text, float letters
}
}

text.maxVisibleCharacters += 1;

onCharacterTyped?.Invoke();
accumulator -= secondsPerLetter;
}
Expand Down