Fix: Initialize SerialReceiver base in CRSFforArduino constructor#102
Closed
tzshin wants to merge 1 commit intoZZ-Cat:Main-Trunkfrom
Closed
Fix: Initialize SerialReceiver base in CRSFforArduino constructor#102tzshin wants to merge 1 commit intoZZ-Cat:Main-Trunkfrom
tzshin wants to merge 1 commit intoZZ-Cat:Main-Trunkfrom
Conversation
Owner
|
Thank you for your first contribution to my project, but the fix you're adding here already exists in another Pull Request. Note Please take the time to go through my Issues and Pull Request sections to see if your contribution already exists before you submit your Issue or Pull Request. I'm literally about to merge #99 into the Main-Trunk (directly after writing this message). Therefore, your Pull Request is rejected on the grounds of it being a duplicate of the fix that's already provided in another Pull Request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi ZZ-Cat,
I discovered an issue where the
CRSFforArduinoconstructor wasn't properly initializing itsSerialReceiverbase class with the providedHardwareSerialobject. As a result, attempts to specify a different hardware serial port (e.g.,new CRSFforArduino(&Serial5);) would default toSerial1, ignoring the user-specified port. This pull request corrects that by ensuring the base class is properly initialized with the user-providedHardwareSerialobject.I've tested the changes using a Teensy 4.0 and an ELRS receiver, confirming the hardware serial port can now be successfully customized. However, as this is my first contribution to any open-source project, I apologize for any possible oversights or missed protocols specific to your project. I'm eager to receive feedback and am fully prepared to make any needed adjustments to meet the project's standards and expectations.
Thank you for considering my contribution. I look forward to any feedback and the opportunity to learn from this experience.
Best regards,
TZShin