refactor(rc channels): Improve readability of RC Channels in Serial Plotter#40
Merged
ZZ-Cat merged 4 commits intoZZ-Cat:Main-Trunkfrom Oct 10, 2023
Merged
refactor(rc channels): Improve readability of RC Channels in Serial Plotter#40ZZ-Cat merged 4 commits intoZZ-Cat:Main-Trunkfrom
ZZ-Cat merged 4 commits intoZZ-Cat:Main-Trunkfrom
Conversation
Signed-off-by: Kristabel28 <kristabel.lim@hotmail.com>
Signed-off-by: Kristabel28 <kristabel.lim@hotmail.com>
Signed-off-by: Kristabel28 <kristabel.lim@hotmail.com>
Signed-off-by: Kristabel28 <kristabel.lim@hotmail.com>
Owner
|
Yup. Looks good to me. =^/.^= FYI: My automations on your PR are janking out on me, and I don't know why. For the time being, I'm gonna go ahead and move this PR forward through to the Main-Trunk, 'cause I read your code and it looks all good. To answer your question: You did fine. =^/.~= |
ZZ-Cat
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor modifications to the Arduino example codes channels.ino and gps_telemetry.ino
Serial.prints more channels. Not sure if I did it right, but I have set it to Serial.print all the channels, based on the channel count crsfProtocol::RC_CHANNEL_COUNT
Arduino serial plotter compatibility for easier readability

Hope this is useful to you!
(did i do it right?)