Skip to content

refactor(rc channels): Improve readability of RC Channels in Serial Plotter#40

Merged
ZZ-Cat merged 4 commits intoZZ-Cat:Main-Trunkfrom
Kristabel28:Main-Trunk
Oct 10, 2023
Merged

refactor(rc channels): Improve readability of RC Channels in Serial Plotter#40
ZZ-Cat merged 4 commits intoZZ-Cat:Main-Trunkfrom
Kristabel28:Main-Trunk

Conversation

@Kristabel28
Copy link
Copy Markdown
Contributor

Minor modifications to the Arduino example codes channels.ino and gps_telemetry.ino

Serial.prints more channels. Not sure if I did it right, but I have set it to Serial.print all the channels, based on the channel count crsfProtocol::RC_CHANNEL_COUNT

Arduino serial plotter compatibility for easier readability
image

Hope this is useful to you!

(did i do it right?)

Signed-off-by: Kristabel28 <kristabel.lim@hotmail.com>
Signed-off-by: Kristabel28 <kristabel.lim@hotmail.com>
Signed-off-by: Kristabel28 <kristabel.lim@hotmail.com>
Signed-off-by: Kristabel28 <kristabel.lim@hotmail.com>
@ZZ-Cat ZZ-Cat added the Arduino IDE ♾️ This is specific to the Arduino IDE label Oct 10, 2023
@ZZ-Cat ZZ-Cat added this to the Version 0.5.0 milestone Oct 10, 2023
@ZZ-Cat ZZ-Cat self-assigned this Oct 10, 2023
@ZZ-Cat
Copy link
Copy Markdown
Owner

ZZ-Cat commented Oct 10, 2023

Yup. Looks good to me. =^/.^=

FYI: My automations on your PR are janking out on me, and I don't know why.
It says "Waiting for status to be reported", but when I check on the actual automations it tells me that it's finished with no tasks.
IIRC, this is something on my end that needs to be figured out in the CI/CD side of things.

For the time being, I'm gonna go ahead and move this PR forward through to the Main-Trunk, 'cause I read your code and it looks all good. To answer your question: You did fine. =^/.~=
Very well done on your first Pull Request.

@ZZ-Cat ZZ-Cat self-requested a review October 10, 2023 07:50
@ZZ-Cat ZZ-Cat changed the title Modifications to Serial.print lines in example code refactor(rc channels): Improve readability of RC Channels in Serial Plotter Oct 10, 2023
@ZZ-Cat ZZ-Cat merged commit 2cc1f48 into ZZ-Cat:Main-Trunk Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arduino IDE ♾️ This is specific to the Arduino IDE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants