stm32: Merge chip flash memory bank regions#282
Merged
mattnite merged 2 commits intoZigEmbeddedGroup:mainfrom Nov 22, 2024
Merged
stm32: Merge chip flash memory bank regions#282mattnite merged 2 commits intoZigEmbeddedGroup:mainfrom
mattnite merged 2 commits intoZigEmbeddedGroup:mainfrom
Conversation
mattnite
approved these changes
Nov 15, 2024
Contributor
mattnite
left a comment
There was a problem hiding this comment.
I'm not sure if the information on where the different regions are located is useful, but I'll allow this patch for now. We can break out that information to users some other way in the future.
tact1m4n3
added a commit
to tact1m4n3/microzig
that referenced
this pull request
Nov 16, 2024
Collaborator
Author
|
I would rather have this merged after #259 because they conflict and merging this afterwards would make it clearer what changes belonged to this patch. |
Contributor
|
@tact1m4n3 please fix the merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge chip flash memory bank regions
The script used for generating all the chip definitions for the stm32 port doesn't merge some regions of flash memory belonging to the same bank. Take this example from a chip definition file in embassy-rs/stm32-data-generated. These regions have to be merged into a single
MemoryRegion. This patch fixes this issue.