Skip to content

Interrupt refactor#369

Merged
mattnite merged 16 commits intoZigEmbeddedGroup:mainfrom
tact1m4n3:interrupts-rework
Mar 7, 2025
Merged

Interrupt refactor#369
mattnite merged 16 commits intoZigEmbeddedGroup:mainfrom
tact1m4n3:interrupts-rework

Conversation

@tact1m4n3
Copy link
Collaborator

@tact1m4n3 tact1m4n3 commented Jan 29, 2025

  • interrupt refactor
  • implement more functionality regarding interrupts on cortex m
  • implement more functionality regarding interrupts on hazard3 (rp2350 riscv)
  • csrs on hazard3
  • add interrupt list to regz

#355

Copy link
Collaborator

@Grazfather Grazfather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just read this over to see if I understood it. It looks good. I don't know riscv or hazard3 very well. Added a few comments/questions.

Copy link
Collaborator

@Grazfather Grazfather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few suggestions in utilities, but those could probably be a followup. I think I found a bug in the rp2xxx build.zig though, with name collisions.

@tact1m4n3
Copy link
Collaborator Author

Thanks for looking into it :))

@Grazfather
Copy link
Collaborator

Looks good to me but I am not able to approve on my own (plus all the builds are failing still)

@tact1m4n3
Copy link
Collaborator Author

Looks good to me but I am not able to approve on my own (plus all the builds are failing still)

I would like to first fix the other architectures (apart from cortex_m and riscv (hazard3)) (this is why ci fails). And there is still functionality to be added in cortex m for interrupts (priorities, pending, etc). But thanks for looking over my pr. I'll mark it as ready for review when I've implemented all of this.

@tact1m4n3 tact1m4n3 marked this pull request as ready for review March 7, 2025 10:44
Copy link
Contributor

@mattnite mattnite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High quality patch, love this direction

@mattnite mattnite merged commit 2e2331d into ZigEmbeddedGroup:main Mar 7, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants