Conversation
Grazfather
left a comment
There was a problem hiding this comment.
I just read this over to see if I understood it. It looks good. I don't know riscv or hazard3 very well. Added a few comments/questions.
Grazfather
left a comment
There was a problem hiding this comment.
Have a few suggestions in utilities, but those could probably be a followup. I think I found a bug in the rp2xxx build.zig though, with name collisions.
|
Thanks for looking into it :)) |
|
Looks good to me but I am not able to approve on my own (plus all the builds are failing still) |
I would like to first fix the other architectures (apart from cortex_m and riscv (hazard3)) (this is why ci fails). And there is still functionality to be added in cortex m for interrupts (priorities, pending, etc). But thanks for looking over my pr. I'll mark it as ready for review when I've implemented all of this. |
mattnite
left a comment
There was a problem hiding this comment.
High quality patch, love this direction
#355