Merged
Conversation
tact1m4n3
force-pushed
the
housekeeping
branch
2 times, most recently
from
0c79260 to
8a3d694
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mainly tried to move stuff out of
core/src/start.ziginto the microzig namespace:microzig_options: From a submodule like a hal or cpu, to get access to microzig_options you had to import root which I think was a little awkward. Now you can domicrozig.options(similar tostd.options)initialize_system_memories: The same thing, it was under root, but now it can be found inmicrozig.utilities.initialize_system_memories().Also I added a microzig option to specify whether you want the name of the error returned from main in the panic message since this depending on
builtin.strip_debug_infodidn't make any sense (as @mattnite mentioned here #621).If these changes are not reasonable please let me know :)