rp2xxx: Remove SchmittTrigger, use Enabled

[Gnyblast]

Code:

const pin_config = rp2xxx.pins.GlobalConfiguration{
    .GPIO29 = .{
        .name = "relay",
        .direction = .out,
    },
    .GPIO28 = .{
        .name = "sensor",
        .direction = .in,
    },
    .GPIO27 = .{
        .name = "capacitor",
        .direction = .in,
    },
    .GPIO4 = .{
        .name = "SDA",
        .function = .I2C0_SDA,
        .schmitt_trigger = .enabled,
        .slew_rate = .slow,
    },
    .GPIO5 = .{
        .name = "SCL",
        .function = .I2C0_SCL,
        .schmitt_trigger = .enabled,
        .slew_rate = .slow,
    },
};

pub fn main() void {
    pin_config.apply();
}

Causing:

install
└─ install generated to light-mcu.uf2
   └─ run elf2uf2 (light-mcu.uf2)
      └─ zig build-exe light-mcu ReleaseSmall thumb-freestanding-eabi 1 errors
/home/guney/.cache/zig/p/mz_port_raspberrypi_rp2xxx-0.0.0-wCvtidmzDQDWXpsuqBY_8dkz96PsJ_rrMKX04haxvjRt/src/hal/pins.zig:944:60: error: expected type 'hal.gpio.Enabled', found 'hal.gpio.SchmittTrigger'
                    gpio.num(gpio_num).set_schmitt_trigger(enabled);

When I dig into the code base. I realized that gpio config uses SchmittTrigger but set_schmitt_trigger in pins.zig uses Enabled so if you pass SchmittTrigger enum the pins.zig fails, if you pass Enabled then gpio.zig fails.

I honestly couldn't see if there was a purpose of having them twice(ish), but looks like causing trouble if I'm not really doing something completely stupid.

[Grazfather]

Looks good. I noticed set_input_enabled uses a bool. We might want to use this enum there for consistency.

[Gnyblast]

Isn't it looking a bit weird in terms of code readability? I mean SchmittTrigger related methods are asking for SchmittTrigger enums but for a set_input_enabled method which has nothing to do with SchmittTrigger, the parameter named SchmittTrigger looked a bit confusing to me.

    pub inline fn set_input_enabled(pin: Pin, enabled: SchmittTrigger) void {
        const pads_reg = pin.get_pads_reg();
        pads_reg.modify(.{ .IE = @intFromEnum(enabled) });
    }

[Gnyblast]

Maybe we should have kept the Enabled enum and then use it for both SchmittTrigger related methods and all other methods that takes enabled bool including also: set_output_disabled.

[Grazfather]

Yes that is what I was suggesting.

[tact1m4n3]

I'd say to keep Enabled for set_schmitt_trigger for now and leave the others as they are.

[Gnyblast]

So what's the final verdict? Enabled should be used in set_input_enabled or not?

[tact1m4n3]

Imo no

[tact1m4n3]

A few minor changes and we're good to go

[Gnyblast]

A few minor changes and we're good to go

All done I guess.

[tact1m4n3]

Nice! Thank you!

[tact1m4n3]

Just a typo :)