Adjust return type of KmmResult.failure#17
Merged
iaik-jheher merged 3 commits intodevelopmentfrom Jan 27, 2026
Merged
Conversation
JesusMcCloud
requested changes
Apr 30, 2025
Collaborator
JesusMcCloud
left a comment
JesusMcCloud
left a comment
There was a problem hiding this comment.
- Make tests succeed
- Check API dump!
- Don't break the API
- Document everything in the changelog
- If API/ABI breaks, we need to discuss a major version release and re-visit everything we have to check if there are other parts that could benefit from a refactor
|
|
iaik-jheher
force-pushed
the
development
branch
from
8a6c6e5 to
d5b5970
Compare
iaik-jheher
force-pushed
the
iaik-jheher-patch-1
branch
2 times, most recently
from
10bdec1 to
a20a743
Compare
Collaborator
|
for the sake of completeness: ObjC has variance, Swift not, so we need to be careful here |
iaik-jheher
force-pushed
the
iaik-jheher-patch-1
branch
from
a20a743 to
da72923
Compare
iaik-jheher
added a commit
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return
KmmResult<Nothing>fromKmmResult.failure. Due to theoutvariance onKmmResult, this is a subtype of anyKmmResult<T>.