Do not throw when matching credentials#515
Do not throw when matching credentials#515acrusage-iaik wants to merge 2 commits intoa-sit-plus:developfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
| data class PresentationExchangeCredentialDisclosure( | ||
| val credential: SubjectCredentialStore.StoreEntry, | ||
| data class PresentationExchangeCredentialDisclosure<Credential: Any>( | ||
| val credential: Credential, |
There was a problem hiding this comment.
Why isn't this a StoreEntry anymore?
There was a problem hiding this comment.
No need to have a fixed type here, fits better in the templated class hierarchies
| pathAuthorizationValidator: PathAuthorizationValidator? = null, | ||
| filterById: String? = null | ||
| ): KmmResult<Map<String, InputDescriptorMatches>> | ||
| ): KmmResult<HolderPresentationExchangeQueryMatchingResult<SubjectCredentialStore.StoreEntry>> |
There was a problem hiding this comment.
Can we find a way to deprecate the old method and convert to the new one?
| dcqlQuery: DCQLQuery, | ||
| filterById: String? = null | ||
| ): KmmResult<DCQLQueryResult<SubjectCredentialStore.StoreEntry>> | ||
| ): KmmResult<HolderDCQLQueryMatchingResult<SubjectCredentialStore.StoreEntry>> |
There was a problem hiding this comment.
Can we find a way to deprecate the old method and convert to the new one?
There was a problem hiding this comment.
We can, but I don't think it's necessary, the class HolderDCQLQueryMatchingResult contains the property credentialQueryMatches with exactly the same name and semantics, so the only thing that changes for library users is the return type. In this sense the new code is "backwards compatible"
2 participants
No description provided.