Update openid4vp claims query to 1.0#518
Update openid4vp claims query to 1.0#518acrusage-iaik wants to merge 2 commits intoa-sit-plus:developfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d61824917b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| DCQLIsoMdocClaimsQuery.SerialNames.NAMESPACE in parameters || DCQLIsoMdocClaimsQuery.SerialNames.CLAIM_NAME in parameters -> DCQLIsoMdocClaimsQuery.serializer() | ||
| else -> DCQLJsonClaimsQuery.serializer() | ||
| DCQLIsoMdocClaimsQuery.SerialNames.INTENT_TO_RETAIN in parameters -> DCQLIsoMdocClaimsQuery.serializer() | ||
| else -> DCQLAmbiguousClaimsQuery.serializer() |
There was a problem hiding this comment.
Returning DCQLAmbiguousClaimsQuery for every claim that omits intent_to_retain makes valid OpenID4VP 1.0 mdoc claims (path only) lose their concrete type when decoded as DCQLClaimsQuery. This breaks the generic construction path in DCQLCredentialQuery.invoke(...), which still casts claims to DCQLIsoMdocClaimsQuery/DCQLJsonClaimsQuery; passing a decoded ambiguous claim into an mdoc query now triggers a ClassCastException even though the claim itself is valid.
Useful? React with 👍 / 👎.
2 participants
This removes backwards compatibility, where ISO MDOC claims path pointers were defined using namespace and claimName, but since our presentations are no longer compatible anyway this should be removed now