fix(poly): typed errors for MultilinearPolynomial TryFrom impls#1380
Open
fix(poly): typed errors for MultilinearPolynomial TryFrom impls#1380
Conversation
Replace `type Error = ()` with typed `MultilinearPolynomialError` enum
in all 9 TryFrom<&MultilinearPolynomial<F>> implementations.
Adds:
- `MultilinearPolynomialError::WrongVariant { expected, got }` with
Display and std::error::Error impls
- Private `variant_name()` helper on MultilinearPolynomial
Resolves TODO(moodlezoup) at lines 484-572.
0xAndoroid
approved these changes
Mar 27, 2026
Comment on lines
+500
to
+519
| #[derive(Debug, Clone, PartialEq)] | ||
| pub enum MultilinearPolynomialError { | ||
| WrongVariant { | ||
| expected: &'static str, | ||
| got: &'static str, | ||
| }, | ||
| } | ||
|
|
||
| impl std::fmt::Display for MultilinearPolynomialError { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| match self { | ||
| Self::WrongVariant { expected, got } => { | ||
| write!(f, "expected {expected} variant, got {got}") | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl std::error::Error for MultilinearPolynomialError {} | ||
|
|
Collaborator
There was a problem hiding this comment.
Let's derive the thiserror::Error
Suggested change
| #[derive(Debug, Clone, PartialEq)] | |
| pub enum MultilinearPolynomialError { | |
| WrongVariant { | |
| expected: &'static str, | |
| got: &'static str, | |
| }, | |
| } | |
| impl std::fmt::Display for MultilinearPolynomialError { | |
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | |
| match self { | |
| Self::WrongVariant { expected, got } => { | |
| write!(f, "expected {expected} variant, got {got}") | |
| } | |
| } | |
| } | |
| } | |
| impl std::error::Error for MultilinearPolynomialError {} | |
| #[derive(Error, Debug, Clone, PartialEq)] | |
| pub enum MultilinearPolynomialError { | |
| #[error("Invalid MultilinearPolynomial: expected {expected}, got {got}")] | |
| WrongVariant { | |
| expected: &'static str, | |
| got: &'static str, | |
| }, | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
type Error = ()with a typedMultilinearPolynomialErrorenum across all 9TryFrom<&MultilinearPolynomial<F>>implementations, resolving the// TODO(moodlezoup)markers.Adds
MultilinearPolynomialError::WrongVariant { expected, got }withDisplayandstd::error::Errorimpls, and a privatevariant_name()helper to report the actual variant on mismatch.