fix(jolt-sumcheck): allow zero-round claims#1489
Closed
quangvdao wants to merge 2 commits into
Closed
Conversation
Permit degree-zero claims when there are no sumcheck rounds, while preserving the degree check for non-empty sumchecks. Co-authored-by: Cursor <cursoragent@cursor.com>
Treat zero as a valid sumcheck degree bound for constant round polynomials, including nonzero-variable claims. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SumcheckClaim::newto accept degree-zero claims generally.Test plan
cargo fmt -qcargo nextest run -p jolt-sumcheck degree_zero sumcheck_claim_new --cargo-quietPosted by Cursor assistant (model: GPT-5.5) on behalf of the user (Quang Dao) with approval.