docs(spec): What changed from v0.3.0 to v1.0#1436
Conversation
Summary of ChangesHello @darrelmiller, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! The v1.0 release of the A2A Protocol marks a significant maturation, focusing on standardization, enhanced type safety, improved developer experience, and enterprise-ready features. It introduces formal adherence to industry specifications, refines core data models and operations, and clarifies behavioral semantics, necessitating updates for existing implementations while providing a more robust and consistent foundation for future development. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive "What's New" document for the A2A Protocol v1.0, which is a great addition for developers migrating from v0.3.0. The document is well-structured and covers the major changes in detail. I've identified a few areas with inconsistencies or inaccuracies that could be improved for clarity. My review includes suggestions to correct a code example, remove a misleading section, and fix minor inconsistencies in terminology and descriptions. Overall, this is a valuable piece of documentation.
…port and OAuth 2.0 updates
a4ca8cd to
96bd3f0
Compare
Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
|
@holtskinner Thank you for the review and suggestions. I have applied your changes. |
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive and well-structured document, docs/whats-new-v1.md, which details the changes from A2A Protocol v0.3.0 to v1.0. The document is thorough, covering major themes, breaking changes, and providing a migration guide for developers. The changes are clearly explained with helpful code examples. I've included a few minor suggestions to improve consistency and clarity in the document. Overall, this is an excellent addition to the project's documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Changes below as they appear in the file. - `blocking` flag existed in 0.3: [source](https://a2a-protocol.org/v0.3.0/specification/#712-messagesendconfiguration-object) - `SendMessage`: remove "MAY return Message"/"MUST return Task" which are not in the spec, remove service parameters mention as they are covered above - streaming was specified for gRPC in proto definition as `returns (stream StreamResponse)` - `SubscribeToTask` is not a new operation - blocking has no effect for streaming operations: [source](https://a2a-protocol.org/latest/specification/#322-sendmessageconfiguration) - `TaskNotCancelableError` was mentioned in 0.3: [source](https://a2a-protocol.org/v0.3.0/specification/#82-a2a-specific-errors) - RFC 7515 was mentioned for Agent Card signatures in 0.3: [source](https://a2a-protocol.org/v0.3.0/specification/#556-agentcardsignature-object), kept only RFC 8785 for canonicalization which wasn't - `agentId` field does not exist and never did - extension declarations (AgentExtension object) did not change between [0.3](https://a2a-protocol.org/v0.3.0/specification/#5521-agentextension-object) and [1.0](https://a2a-protocol.org/latest/specification/#444-agentextension) - Mutual TLS existed in 0.3: [source](https://a2a-protocol.org/v0.3.0/specification/#553-securityscheme-object) - subscribing to tasks not originally created via streaming is not a behavior change and is not explicitly mentioned in 1.0 - `token` is not removed from `PushNotificationConfig`: [source](https://a2a-protocol.org/latest/specification/#431-pushnotificationconfig) - `configId` does not exist in `PushNotificationConfig` ([source](https://a2a-protocol.org/latest/specification/#431-pushnotificationconfig)) and `id` was there in 0.3 ([source](https://a2a-protocol.org/v0.3.0/specification/#68-pushnotificationconfig-object)) - `PushNotificationNotSupportedError` existed in 0.3: [source](https://a2a-protocol.org/v0.3.0/specification/#82-a2a-specific-errors) - `SendMessageRequest` example fixed to match the spec - `createdAt` and `lastModified` do not exist in `Task`: [source](https://a2a-protocol.org/latest/specification/#411-task) - changes to nested `Task` objects removed as they are covered in respective sections (`TaskStatus`, `Message`, `Artifact`) - `timestamp` was not added to `Message`: [source](https://a2a-protocol.org/latest/specification/#414-message) - there is no "stricter typing" for `metadata` - "retained" should not be in the changelog - `createdAt` was not added to `Artifact`: [source](https://a2a-protocol.org/latest/specification/#417-artifact) - `signatures` field was there in 0.3: [source](https://a2a-protocol.org/v0.3.0/specification/#55-agentcard-object-structure) Re #1436. Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com> Co-authored-by: Darrel <darrmi@microsoft.com>
No description provided.