Skip to content

docs(spec): Fix MTLS scheme proto embedding#1462

Merged
ishymko merged 4 commits intoa2aproject:mainfrom
ishymko:ishymko/fix-mtls-proto-embedding
Feb 10, 2026
Merged

docs(spec): Fix MTLS scheme proto embedding#1462
ishymko merged 4 commits intoa2aproject:mainfrom
ishymko:ishymko/fix-mtls-proto-embedding

Conversation

@ishymko
Copy link
Copy Markdown
Member

@ishymko ishymko commented Feb 9, 2026

Currently properties for MutualTlsSecurityScheme are not renderred (source):
image

This PR makes casing consistent for both mkdocs anchors and heading.

Tested via mkdocs serve:
image

Re #1460 (comment)

@ishymko ishymko requested a review from darrelmiller February 9, 2026 18:17
@ishymko ishymko requested a review from a team as a code owner February 9, 2026 18:17
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a documentation rendering issue where the properties for the MutualTLSSecurityScheme were not being displayed in the generated documentation. The change involves a precise correction in the documentation source to ensure these security scheme details are correctly embedded and visible to readers.

Highlights

  • Documentation Fix: Corrected a typo in the proto_to_table function call within docs/specification.md to properly render MutualTLSSecurityScheme properties, which were previously not displayed.
Changelog
  • docs/specification.md
    • Corrected the second argument of the proto_to_table function from "MutualTlsSecurityScheme" to "MutualTLSSecurityScheme" to ensure proper rendering of the MTLS security scheme properties.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a rendering issue in the specification documentation by correcting the casing of a Protobuf message name in a macro call. The change is straightforward and effective. I've added one minor comment regarding the inconsistency this introduces with the source .proto file, suggesting a potential long-term improvement for better maintainability.

@holtskinner
Copy link
Copy Markdown
Member

Note: #1427 will also fix this issue for future updates as well

@ishymko ishymko merged commit 3f6ad2d into a2aproject:main Feb 10, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants