fix: Remove TempLoggerWrapper and use logback as the logging implementation.#158
Conversation
… logging implementation for tests. Signed-off-by: Sun Yuhan <sunyuhan1998@users.noreply.github.com>
There was a problem hiding this comment.
Summary of Changes
Hello @sunyuhan1998, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly refactors the application's logging mechanism by deprecating a custom TempLoggerWrapper in favor of logback, a robust and widely-adopted logging framework. The change involves updating Maven dependencies, configuring logback for test environments, and modifying existing code to directly use slf4j with logback as its underlying implementation. This aims to enhance logging capabilities, improve maintainability, and align with industry best practices.
Highlights
- Logging System Migration: The custom
TempLoggerWrapperhas been removed and replaced withlogbackas the primary logging implementation across the application. This standardizes the logging infrastructure. - Dependency Management Updates: The
logback-classicdependency has been added to the rootpom.xmlfor central management and tosdk-server-common/pom.xmlfor test scope. Crucially, exclusions for JBoss logging components (e.g.,jboss-logging,jboss-logmanager) were added to thequarkus-arcdependency to prevent conflicts and ensurelogbackis the active logging backend. - Logging Configuration: A new
logback.xmlconfiguration file has been introduced undersdk-server-common/src/test/resources. This file provides a basic console appender setup for test environments, allowing for immediate visibility of logs at thedebuglevel.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request successfully removes the temporary TempLoggerWrapper and integrates logback as the standard logging implementation for tests. The changes are clean and align with the PR's objective. I've added a couple of suggestions to improve maintainability and code style consistency.
Signed-off-by: Sun Yuhan <sunyuhan1998@users.noreply.github.com>
Signed-off-by: Sun Yuhan <sunyuhan1998@users.noreply.github.com>
kabir
left a comment
There was a problem hiding this comment.
Thanks @sunyuhan1998! One very minor comment, apart from that I think it looks good.
I've verified that the tests in the sdk-server-common show logs in my IDE, and also when running from command-line the logs end up in the surefire reports.
Also, when running the Quarkus test in my IDE, I see the log messages.
|
@kabir The test scope has been added as a dependency. Please help review it. Thank you! |
|
Thanks! |
Hi @kabir , as we discussed previously: #94. This PR removes the
TempLoggerWrapperand useslogbackas the default logging implementation.logbackautomatically loads thelogback.xmlfile from the classpath, and we can easily adjust the logging level by modifying this file.Fixes #94