Skip to content

fix: Remove TempLoggerWrapper and use logback as the logging implementation.#158

Merged
kabir merged 3 commits intoa2aproject:mainfrom
sunyuhan1998:fix-issue-94-plan-logback
Jul 4, 2025
Merged

fix: Remove TempLoggerWrapper and use logback as the logging implementation.#158
kabir merged 3 commits intoa2aproject:mainfrom
sunyuhan1998:fix-issue-94-plan-logback

Conversation

@sunyuhan1998
Copy link
Contributor

@sunyuhan1998 sunyuhan1998 commented Jul 4, 2025

Hi @kabir , as we discussed previously: #94. This PR removes the TempLoggerWrapper and uses logback as the default logging implementation.

logback automatically loads the logback.xml file from the classpath, and we can easily adjust the logging level by modifying this file.

Fixes #94

… logging implementation for tests.

Signed-off-by: Sun Yuhan <sunyuhan1998@users.noreply.github.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @sunyuhan1998, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the application's logging mechanism by deprecating a custom TempLoggerWrapper in favor of logback, a robust and widely-adopted logging framework. The change involves updating Maven dependencies, configuring logback for test environments, and modifying existing code to directly use slf4j with logback as its underlying implementation. This aims to enhance logging capabilities, improve maintainability, and align with industry best practices.

Highlights

  • Logging System Migration: The custom TempLoggerWrapper has been removed and replaced with logback as the primary logging implementation across the application. This standardizes the logging infrastructure.
  • Dependency Management Updates: The logback-classic dependency has been added to the root pom.xml for central management and to sdk-server-common/pom.xml for test scope. Crucially, exclusions for JBoss logging components (e.g., jboss-logging, jboss-logmanager) were added to the quarkus-arc dependency to prevent conflicts and ensure logback is the active logging backend.
  • Logging Configuration: A new logback.xml configuration file has been introduced under sdk-server-common/src/test/resources. This file provides a basic console appender setup for test environments, allowing for immediate visibility of logs at the debug level.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully removes the temporary TempLoggerWrapper and integrates logback as the standard logging implementation for tests. The changes are clean and align with the PR's objective. I've added a couple of suggestions to improve maintainability and code style consistency.

Signed-off-by: Sun Yuhan <sunyuhan1998@users.noreply.github.com>
Signed-off-by: Sun Yuhan <sunyuhan1998@users.noreply.github.com>
Copy link
Collaborator

@kabir kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sunyuhan1998! One very minor comment, apart from that I think it looks good.

I've verified that the tests in the sdk-server-common show logs in my IDE, and also when running from command-line the logs end up in the surefire reports.

Also, when running the Quarkus test in my IDE, I see the log messages.

@sunyuhan1998
Copy link
Contributor Author

@kabir The test scope has been added as a dependency. Please help review it. Thank you!

@sunyuhan1998 sunyuhan1998 requested a review from kabir July 4, 2025 09:55
@kabir kabir merged commit 9a8e9e5 into a2aproject:main Jul 4, 2025
2 checks passed
@kabir
Copy link
Collaborator

kabir commented Jul 4, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove TempLoggerWrapper and configure debug/trace logging for tests

2 participants