test: fix naming in card-resolver.spec.ts

[ishymko]

It had nothing to do with 0.3 and 1.0.

Re #344

[github-actions]

🧪 Code Coverage

⬇️ Download Full Report

No coverage changes.

Generated by coverage-comment.yml

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the existing test suite for the DefaultAgentCardResolver by addressing inconsistencies in variable naming and protocol versioning. The changes aim to enhance the readability and accuracy of the tests, ensuring they correctly reflect the expected behavior of agent card resolution without altering any production code.

Highlights

• Test Naming Convention: Renamed several test variables in card-resolver.spec.ts (e.g., v03AgentCard to JsonSchemaAgentCard, v1ProtoAgentCard to ProtoAgentCard) to improve clarity and accuracy, as the previous names were misleading.
• Protocol Version Correction: Corrected the protocolVersion from '1.0.0' to '0.3.0' in the expectedAgentCard and ProtoAgentCard definitions within the test file, aligning them with the intended test scenario.
• Test Description Updates: Adjusted the descriptions in the it.each test block to reflect the new variable names and simplified protocol version references, making the tests easier to understand.

Changelog

• test/client/card-resolver.spec.ts
  • Updated protocolVersion in expectedAgentCard to '0.3.0'.
  • Renamed v03AgentCard to JsonSchemaAgentCard.
  • Renamed v1ProtoAgentCard to ProtoAgentCard and updated its protocolVersion to '0.3.0'.
  • Renamed v1ProtoAgentCardWithSkill to ProtoAgentCardWithSkill.
  • Updated test descriptions in the it.each block to use the new variable names and simplified protocol version references.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the test file test/client/card-resolver.spec.ts to improve clarity and correctness. Variable names have been updated to be more descriptive of their content (JSON Schema vs. Protobuf) rather than being tied to protocol versions. Additionally, the protocolVersion in the test data has been corrected to 0.3.0, which aligns with the specification details being tested. These changes make the tests easier to understand and maintain. The implementation is solid.