-
Notifications
You must be signed in to change notification settings - Fork 5.7k
update doc to remind contributors to activate hermit and document minimal npm and node version #6727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update doc to remind contributors to activate hermit and document minimal npm and node version #6727
Changes from 3 commits
ec6c605
3db068f
3970381
84425c5
670718b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| registry=https://registry.npmjs.org/ | ||
| engine-strict=true | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,8 @@ | |
| "version": "1.21.0", | ||
| "description": "Goose App", | ||
| "engines": { | ||
| "node": "^24.0.0" | ||
| "node": ">=24.10.0", | ||
| "npm": ">=11.6.1" | ||
|
||
| }, | ||
| "main": ".vite/build/main.js", | ||
| "scripts": { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
engine-strict=trueand"node": "^24.0.0"inui/desktop/package.json, anynpm installin this package (including theBundle Desktop (Windows)workflow which currently uses Node 22 viaactions/setup-node) will now fail the engine check; please either align the CI/workflow Node version with^24.0.0or relax/removeengine-strictso existing release workflows continue to run.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lifeizhou-ap is this valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, what copilot said is valid. Now I decided to remove it and not to enforce the check. I've also update the doc so that it is clear for users about the prerequisite of hermit activation