fix processing of the args option #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes passing of arguments to commands. It also preserves the replacement placeholder values per request. Additionally, placeholders can now also be used in global commands. The previous approach was prone to cause race conditions on heavily loaded proxies due to using shared memory for the replaced arguments which has also been addressed.
|
Thanks a lot @schlagert, I was debugging this for a while. There really is a regression introduced in the last PR. Time for pinning my go modules. |
Contributor
Author
|
Is there anything we can do to get this PR approved/merged? I think the current state of master is pretty much broken. |
|
@abiosoft friendly ping |
abiosoft
approved these changes
Sep 14, 2024
abiosoft
changed the title
Owner
|
Thanks @schlagert for the fix, and everyone else for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging the latest PR broke passing of arguments to commands. This PR will fix this issue. It also preserves the replacement placeholder values per request. Additionally, placeholders can now also be used in global commands.
The previous approach was prone to cause race conditions on heavily loaded proxies due to using shared memory for the replaced arguments which has also been addressed.