Skip to content

EventEmitter: allow signatures with no event arg #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
owenpearson merged 3 commits into from
Nov 2, 2022
Merged

EventEmitter: allow signatures with no event arg #350

owenpearson merged 3 commits into from
Nov 2, 2022

Conversation

@owenpearson
Copy link
Member

@owenpearson owenpearson commented Nov 1, 2022

  • Allows users to listen to all ConnectionStateChanges
  • Allows us to add canonical docstrings to the EventEmitter interface

@owenpearson owenpearson merged commit 98ea745 into integration/realtime Nov 2, 2022
@owenpearson owenpearson deleted the event-emitter-on branch November 2, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuintinWillison QuintinWillison Awaiting requested review from QuintinWillison

1 more reviewer

@mohyour mohyour mohyour approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@owenpearson @mohyour