Skip to content

[SDK-3807] Implement and test empty inner message fields #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sacOO7 merged 8 commits into from
Aug 18, 2023
Merged

[SDK-3807] Implement and test empty inner message fields #517

sacOO7 merged 8 commits into from
Aug 18, 2023

Conversation

@sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Aug 17, 2023 •
edited
Loading

@github-actions github-actions bot temporarily deployed to staging/pull/517/features August 17, 2023 15:48 Inactive
@sacOO7 sacOO7 changed the title Added poetry.toml config to set local virtualenv Implement and test empty inner message fields Aug 17, 2023
@github-actions github-actions bot temporarily deployed to staging/pull/517/features August 17, 2023 18:06 Inactive
@sacOO7 sacOO7 changed the title Implement and test empty inner message fields [SDK-3807] Implement and test empty inner message fields Aug 17, 2023
@github-actions github-actions bot temporarily deployed to staging/pull/517/features August 17, 2023 21:15 Inactive
@sacOO7 sacOO7 requested review from AndyTWF and owenpearson August 17, 2023 21:16
@github-actions github-actions bot temporarily deployed to staging/pull/517/features August 17, 2023 21:43 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/517/features August 18, 2023 09:34 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/517/features August 18, 2023 09:41 Inactive
@sacOO7 sacOO7 marked this pull request as ready for review August 18, 2023 10:41
@github-actions github-actions bot temporarily deployed to staging/pull/517/features August 18, 2023 10:41 Inactive
@sacOO7 sacOO7 force-pushed the fix/inner-message-empty-fields branch from 087cc28 to 22dbfb5 Compare August 18, 2023 10:43
@sacOO7 sacOO7 requested a review from stmoreau August 18, 2023 10:52
AndyTWF
AndyTWF approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@AndyTWF AndyTWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍🏻

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Aug 18, 2023

Thanks @AndyTWF!

@sacOO7 sacOO7 merged commit 8338608 into main Aug 18, 2023
@sacOO7 sacOO7 deleted the fix/inner-message-empty-fields branch August 18, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyTWF AndyTWF AndyTWF approved these changes

@owenpearson owenpearson Awaiting requested review from owenpearson

@stmoreau stmoreau Awaiting requested review from stmoreau

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement / Add tests for TM1,TM2,TM3 Message spec

3 participants

@sacOO7 @AndyTWF