Merged
Conversation
It's now able to fetch JSON from PyPI API with inputing thr pypi purl with version and pass it to scan and return the scan result. ToDo item is the second part of the issue Signed-off-by: Chin Yeung Li <tli@nexb.com>
…he PURL. Signed-off-by: Chin Yeung Li <tli@nexb.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>
…ackages are available for a single version. Signed-off-by: Chin Yeung Li <tli@nexb.com>
JonoYang
reviewed
Mar 25, 2025
Member
JonoYang
left a comment
JonoYang
left a comment
There was a problem hiding this comment.
@chinyeungli Code looks good so far, just needs some tests
minecode/collectors/pypi.py
Outdated
| packages = build_packages(package_json, package_url) | ||
|
|
||
| for package in packages: | ||
| # package.extra_data["package_content"] = PackageContentType.SOURCE_ARCHIVE |
pombredanne
changed the title
Correct typo Signed-off-by: Chin Yeung Li <tli@nexb.com> Co-authored-by: Jono Yang <JonoYang@users.noreply.github.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>
JonoYang
requested changes
Mar 28, 2025
| if not url: | ||
| continue | ||
|
|
||
| packagetype = None |
Member
There was a problem hiding this comment.
@chinyeungli The changes you made here are breaking the tests in for minecode/tests/miners/test_pypi.py https://dev.azure.com/nexB/purldb/_build/results?buildId=15751&view=logs&j=0cfca3bc-aa91-566e-292e-f125b0e3456a&t=0ab68744-bd25-5ccd-cfbc-bd1d5e7178c3&l=1033
Signed-off-by: Chin Yeung Li <tli@nexb.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>
Signed-off-by: Chin Yeung Li <tli@nexb.com>
Member
|
@chinyeungli LGTM! merging |
JonoYang
added a commit
that referenced
this pull request
Apr 14, 2025
Collect pypi PURL ondemand #468
39 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file_namequalifier when multiple packages are available for a single version.