Ambiguous Detections ToDo items#3353
Merged
AyanSinhaMahapatra merged 6 commits intolicense-detection-improvements-and-reviewfrom Apr 27, 2023
Merged
Ambiguous Detections ToDo items#3353AyanSinhaMahapatra merged 6 commits intolicense-detection-improvements-and-reviewfrom
AyanSinhaMahapatra merged 6 commits intolicense-detection-improvements-and-reviewfrom
Conversation
* Adds a new --todo post scan option to review potential ambiguous license/package detections * Adds a `todo` top level attribute with these review items which is a `ToDo` list for the reviewer Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
todo-review
branch
from
69d662c to
c9dc26b
Compare
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
todo-review
branch
from
e5d2fd5 to
d4124b2
Compare
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
4 tasks
pombredanne
approved these changes
Apr 27, 2023
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
LGTM! Please add a changelog too.
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
merged commit dd2c3f7
into
license-detection-improvements-and-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3122
Tasks
Run tests locally to check for errors.