Skip to content

Fix package scan only performance#3423

Merged
AyanSinhaMahapatra merged 3 commits intodevelopfrom
fix-package-scan-only-performance
Jun 7, 2023
Merged

Fix package scan only performance#3423
AyanSinhaMahapatra merged 3 commits intodevelopfrom
fix-package-scan-only-performance

Conversation

@AyanSinhaMahapatra
Copy link
Copy Markdown
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jun 7, 2023

Fixes a performance issue issue arising out of license detection on files happening in a single-threaded process_codebase step when the
license CLI option is disabled for a package scan.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

This commit disables license detection on files happening when the
license CLI option is disabled for a package scan.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
"holder": "Jiri Pirko\nAndrew Ayer",
"declared_license_expression": "lgpl-2.1-plus AND lgpl-2.1",
"declared_license_expression_spdx": "LGPL-2.1-or-later AND LGPL-2.1-only",
"license_detections": [
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking this seperately at: #3424

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the fix-package-scan-only-performance branch from 55aac5d to 9d42d1e Compare June 7, 2023 15:45
Copy link
Copy Markdown
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Copy link
Copy Markdown
Member Author

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 94d4fe6 into develop Jun 7, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the fix-package-scan-only-performance branch June 7, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants