Fix licenses data in summary plugin #3430
Merged
pombredanne merged 2 commits intodevelopfrom Jun 29, 2023
Merged
Conversation
This makes the top level license detection sorted, first in alphabetical order, then in descending order of detection_count and then on the identifier/UUID. Also regens tests for the same. Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Fix license tallies to be keyed by license expressions for each license detection, instead of the detected_license_expression for a file. Also take into account package license detections. Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
fix-summary-license
branch
from
c079489 to
e367fa2
Compare
pombredanne
approved these changes
Jun 29, 2023
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
LGTM! you may want to check your usage of constants inside functions for improved readability (e.g., use less of these ;) )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Tasks
Run tests locally to check for errors.