Fixed epoch parser failing for numeric values#3520
Merged
AyanSinhaMahapatra merged 1 commit intoaboutcode-org:developfrom Oct 10, 2023
Merged
Fixed epoch parser failing for numeric values#3520AyanSinhaMahapatra merged 1 commit intoaboutcode-org:developfrom
AyanSinhaMahapatra merged 1 commit intoaboutcode-org:developfrom
Conversation
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Thanks for the PR @OmkarPh
See a few nits for your consideration
| test_file = self.get_test_loc('rpm/header/zziplib-0.11.15-3sf.i586.rpm') | ||
| self.check_rpm_tags(test_file) | ||
|
|
||
| def test_rpm_tags_apache_commons_io_2_4_12_el7_noarch_rpm(self): |
Member
There was a problem hiding this comment.
Maybe test_get_rpm_tags_can_parse_numeric_values is a better name?
Contributor
Author
There was a problem hiding this comment.
the tests above also check for the same function right
Should I update those too?
Member
|
You can use this truncated RPM that I shortened using an hex binary editor (ghex) |
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
OmkarPh
force-pushed
the
fix/rpm-epoch-error
branch
from
3d5f7ec to
2405a89
Compare
Contributor
Author
Thanks, I've force pushed (and tested) with this truncated file |
AyanSinhaMahapatra
approved these changes
Oct 10, 2023
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
LGTM!
Thanks++ @OmkarPh
Merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3489
Tasks
Run tests locally to check for errors.