feat: add synth runtime modulation rack#1018
Draft
ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-runtime-voicesfrom
Draft
feat: add synth runtime modulation rack#1018ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-runtime-voicesfrom
ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-runtime-voicesfrom
Conversation
This was referenced Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SynthEngineso canonical subtractive LFO settings drive live playbackamp,pan,filterCutoff, andpitchSynthEnginetestsDetails
createSynthModulationSpec(...)helper alongside the existing runtime-spec mappingTremolo,AutoPanner,AutoFilter,Vibrato) per track and preview synth when the subtractive LFO is enabledvoice -> optional modulation rack -> gain -> destinationValidation
npx tsc --noEmitnpx vitest run --environment node src/engine/__tests__/SynthEngine.test.tsnpx vitest run --environment node src/utils/__tests__/trackInstrument.test.ts tests/unit/sessionLaunchModes.test.ts tests/unit/sessionLegato.test.tsnpm run buildhttp://127.0.0.1:4174/: opened Piano Roll, confirmed synth editor renders, toggled LFO on, changed target toamp, and verified the update writes throughwindow.__store.getState().project.tracks[*].instrument.settings.lfoNotes
Node v18.16.0 + jsdom/html-encoding-sniffer/@exodus/bytesESM compatibility issue in the sharednode_modulestree. The new runtime coverage added in this PR was validated under--environment node, and the existing build stays green.