feat: expose filter envelope controls in synth editor#1043
Draft
ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-offline-render-parityfrom
Draft
feat: expose filter envelope controls in synth editor#1043ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-offline-render-parityfrom
ChuxiJ wants to merge 1 commit intofeat/v0.0.x-sprint-01-offline-render-parityfrom
Conversation
31 tasks
Author
|
Triage: Merge candidate — Filter envelope controls for synth editor. Standalone feature, good UX improvement. Needs rebase check. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
track.instrumentWhy
This closes the Sprint 01 gap between runtime support and editor affordance:
filterEnvelopealready drives subtractive playback, but the UI did not expose those parameters. It also advances the research-backed Phase 2 synth editor scope (Filter ADSR + LFO with routing).Verification
npx tsc --noEmitnpm run buildkeyboardpianoRolltrackFilter Env Amtto0.42Filt Env Releaseto1.8window.__store.getState().project.tracks[*].instrument.settings.filterEnvelopereflects the new valuesKnown limitation
npx vitest run tests/unit/SynthInstrumentEditor.test.tsxis still blocked on this machine by the existingNode 18 + jsdom + @exodus/bytesworker startup issue. The test file was updated, but local execution could not complete until that environment issue is resolved.