feat: add latency calibration UI with auto-detection and manual override#1115
Merged
feat: add latency calibration UI with auto-detection and manual override#1115
Conversation
…ide (closes #1106) - Add latencyMsToSamples() utility to convert ms to sample counts - Add "Re-detect" button in Settings to re-measure audio latency on demand - Display latency in both ms and samples at current sample rate - Add comprehensive tests for ms-to-samples conversion, manual override precedence, and persistence across normalize calls https://claude.ai/code/session_01KYEjWp985CYRCcSm9J46ps
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
latencyMsToSamples()utility to convert latency from milliseconds to audio samples at the current sample rateCloses #1106
Test plan
npx tsc --noEmitpasses with 0 errorsnpm testpasses (17 tests in playbackLatency.test.ts, all green)npm run buildsucceedshttps://claude.ai/code/session_01KYEjWp985CYRCcSm9J46ps