feat: add TokContext as type (now that not exported as type from acorn)#139
Open
brettz9 wants to merge 1 commit intoacornjs:mainfrom
Open
feat: add TokContext as type (now that not exported as type from acorn)#139brettz9 wants to merge 1 commit intoacornjs:mainfrom
TokContext as type (now that not exported as type from acorn)#139brettz9 wants to merge 1 commit intoacornjs:mainfrom
Conversation
This was referenced Oct 27, 2025
brettz9
force-pushed
the
types
branch
2 times, most recently
from
1ca4a97 to
2c18b84
Compare
…orn) Also: - fix: pass attw validation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With your unreleased changes merged into
master, there has since become a problem with some referenced types no longer being present in acorn.In this PR, I made the parser type argument of
overrideasanydue to the complexity of the Parser class not being exported from acorn. See acornjs/acorn#1260 and acornjs/acorn#1404 .