Adding parameter to configure the runner set name.#2279
Merged
Conversation
chrispat
requested review from
a team,
mumoshu,
nikola-jokic and
toast-gear
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hello! Thank you for your contribution.
Please review our contribution guidelines to understand the project's testing and code conventions.
TingluoHuang
force-pushed
the
runner-set-name
branch
2 times, most recently
from
7b0d751 to
2cf48ba
Compare
| } | ||
|
|
||
| log.Info("Successfully removed finalizer after cleanup") | ||
| return ctrl.Result{}, nil |
Member
There was a problem hiding this comment.
noticed we forgot to return early during test locally.
| } | ||
|
|
||
| log.Info("Successfully removed finalizer after cleanup") | ||
| return ctrl.Result{}, nil |
Member
There was a problem hiding this comment.
noticed we forgot to return early during test locally.
TingluoHuang
force-pushed
the
runner-set-name
branch
from
4e3023f to
a988868
Compare
TingluoHuang
force-pushed
the
runner-set-name
branch
from
a988868 to
7065dc7
Compare
rentziass
approved these changes
Mar 3, 2023
Merged
unpollito
pushed a commit
to DistruApp/actions-runner-controller
that referenced
this pull request
Jan 21, 2026
Co-authored-by: TingluoHuang <TingluoHuang@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the runner set name is always the same as the helm release name. However, there are scenarios where one might want to have the same runner names across multiple runner groups and organizations. Given the helm release still has to be unique per namespace it would be useful to optionally provide a runner set name.