Skip to content

Fix helm chart when containerMode.type=dind.#2291

Merged
TingluoHuang merged 1 commit into
masterfrom
users/tihuang/fixdindchart
Feb 15, 2023
Merged

Fix helm chart when containerMode.type=dind.#2291
TingluoHuang merged 1 commit into
masterfrom
users/tihuang/fixdindchart

Conversation

@TingluoHuang

@TingluoHuang TingluoHuang commented Feb 15, 2023

Copy link
Copy Markdown
Member

The chart is not rendered properly when --set containerMode.type=dind

It was rendered to:

     containers:
      - name: runner
        command: [/actions-runner/run.sh]
        image: ghcr.io/actions/actions-runner:latest
        env:
        volumeMounts:
          - name: work
            mountPath: /actions-runner/_work
          - name: dind-cert
            mountPath: /certs/client

Notice the env section is empty due to the bug.

@@ -208,18 +208,18 @@ env:
{{- end }}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hide whitespace when reviewing.

TLDR, the bug is {{- end }} get added in the wrong line.

@TingluoHuang TingluoHuang merged commit d962714 into master Feb 15, 2023
@TingluoHuang TingluoHuang deleted the users/tihuang/fixdindchart branch February 15, 2023 19:29
unpollito pushed a commit to DistruApp/actions-runner-controller that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants