Refactor actions client error to include request id #3430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-jokic
requested review from
a team,
mumoshu,
rentziass and
toast-gear
as code owners
nikola-jokic
added
the
gha-runner-scale-set
rentziass
reviewed
Apr 16, 2024
| strings.Contains(actionsError.ExceptionName, "JobStillRunningException") { | ||
| log.Info("Runner is still running the job. Re-queue in 30 seconds") | ||
| return ctrl.Result{RequeueAfter: 30 * time.Second}, nil | ||
| if err == nil { // if NO error |
Member
There was a problem hiding this comment.
Why do we need to flip this? It's a bit counter-intuitive to have the happy path indented 🤔
Collaborator
Author
There was a problem hiding this comment.
Good point! I flipped this because error handling was huge, so I wanted to exit here to avoid having large if body (which I dislike more than not having happy path on the left 😄 ) Great point, I'll change it! Thanks!
Co-authored-by: Francesco Renzi <rentziass@gmail.com>
rentziass
approved these changes
Apr 16, 2024
Merged
unpollito
pushed a commit
to DistruApp/actions-runner-controller
that referenced
this pull request
Jan 21, 2026
Co-authored-by: Francesco Renzi <rentziass@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to change the actions error, and introduce a
GitHubAPIErrorto log the request ID whenever we receive a response from the server.This can help diagnose problems such as the one described here: #3204