Conversation
|
Just saw a lot of PRs for the same: The launched command was always: 2.47.1: no problem2.48.0: problem2.48.1: problem2.49.0: no problem |
|
Great investigation, and thanks for going the extra mile to test across multiple Git versions. Confirming from the logs: 2.47.1 and 2.49.0 correctly fetch tags as expected 2.48.0 and 2.48.1 fail to fetch tags even with --tags This validates that the issue is specific to the 2.48.x series and not related to actions/checkout logic directly — but it's great to see this PR work around that inconsistency with a robust fix. |
|
hello all, would there need to be any additional changes for this PR? |
|
Whens this coming out!? Im writing a script that needs it! |
|
I'm guessing when you add five more exclamation marks? 😁 |
- actions/checkout does not fetch tags when fetch-depth is set (see actions/checkout#2200) -> fetch the tags manually
|
Stil not working in v5.0.0 |
Closes #1467
Closes #1471
Closes #1662
Closes #1781
Closes #2039
Closes #2041
Closes #2106
Closes #2127
Closes #2199
This fix would allow one to specify
fetch-tags.Right now, it doesn't work as advertised (ie: no tags were fetched, even when configured as
true)With this change, it'll add a "--tags" cli entry, which will fetch the tags - regardless of the provided depth.
EDIT: after checking the other tickets and @TingluoHuang 's comment in #2039, I dug deeper and provided an all-encompassing fix for the wrong behaviour in git 2.48.