Skip to content

Add warning if python version set to empty value #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marko-zivic-93 merged 5 commits into from
May 4, 2022
Merged

Add warning if python version set to empty value #396

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ac4e858
Add warning if python version set to empty value
dsame Apr 29, 2022
22daa09
Add generated files
dsame Apr 29, 2022
0b56b76
Improve wording
dsame Apr 29, 2022
e31727c
Improve warning message
dsame May 4, 2022
8f73c14
Formatting
dsame May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dist/setup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6112,6 +6112,9 @@ function run() {
yield cacheDependencies(cache, pythonVersion);
}
}
else {
core.warning("Step input 'python-version' is not set, the OS native python version will be used");
}
const matchersPath = path.join(__dirname, '../..', '.github');
core.info(`##[add-matcher]${path.join(matchersPath, 'python.json')}`);
}
Expand Down
4 changes: 4 additions & 0 deletions src/setup-python.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ async function run() {
if (cache && isCacheFeatureAvailable()) {
await cacheDependencies(cache, pythonVersion);
}
} else {
core.warning(
"Step input 'python-version' is not set, the OS native python version will be used"
Comment thread
dsame marked this conversation as resolved.
Outdated
);
}
const matchersPath = path.join(__dirname, '../..', '.github');
core.info(`##[add-matcher]${path.join(matchersPath, 'python.json')}`);
Expand Down