Stale action skips PRs with no clear reason

[aduh95]

Let's take this PR as an example: nodejs/node#24402

It hasn't receive any comment or any update at the time of writing since the stalled label was added to it: there is no activity to be seen on the GitHub UI. It's unclear to me why the PR is not closed by the GA. Link to the console output: https://github.com/nodejs/node/runs/1272514028?check_suite_focus=true#step:2:422:

Found issue: issue #24402 - test: add a test to make sure the modules can be required independently last updated 2020-10-06T14:03:13Z (is pr? true)
Found a stale pr
Checking for label stalled on issue #24402
Issue #24402 marked stale on: 2020-07-07T14:44:02Z
Checking for comments on issue #24402 since 2020-07-07T14:44:02Z
Comments not made by mmarchini or another bot: 0
Issue #24402 has been commented on: false
Issue #24402 has been updated: true
Stale pr is not old enough to close yet (hasComments? false, hasUpdate? true

I have a few issues on the last line:

• It says it's "not old enough", but that's confusing: I'd say it's been old enough for quite some time.
• It says it hasn't been commented on, that's also unclear: does it mean "no auto-comment notifying the users the PR will be closed"? Or that it hasn't been commented since the label was added? Should it be true or false to allow the PR to be auto-closed?
• It says it "has been updated": is there a way to know what "update" it refers to? Should it be true or false to allow the PR to be auto-closed?

In the end, I don't know if this is a bug in the Stale action, in our configuration, or just normal behaviour that I don't understand.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

[aduh95]

A documentation update would be appreciated.

[hross]

If you would like to make some documentation updates in a PR I can review it and see if we can get the changes merged.

[aduh95]

If you would like to make some documentation updates in a PR I can review it and see if we can get the changes merged.

The thing is I don't know what the behaviour actually is – that's the reason I opened this issue in the first place. I can see that some PRs are not getting closed, but I don't understand why.

[C0ZEN]

@aduh95

It says it's "not old enough", but that's confusing: I'd say it's been old enough for quite some time.

An issue will be closed only if:

• It is already stalled
• It has reached the minimum number of days before closing it (days-before-close option)
• No new comments were added
• No update was done

In your case it seems that an update was made

It says it hasn't been commented on, that's also unclear: does it mean "no auto-comment notifying the users the PR will be closed"? Or that it hasn't been commented since the label was added? Should it be true or false to allow the PR to be auto-closed?

I think that the response above sums up.

It says it "has been updated": is there a way to know what "update" it refers to? Should it be true or false to allow the PR to be auto-closed?

It take the date provided by GitHub (updated_at) and calculate the number of days.
The response above sums up once again: if stalled and the days-before-close option is smaller than the calculated number of days then it means that no update was done

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days