Conversation
- rename all test files to test_ - I find this very useful when I want to open the corresponding test file using my editors fuzzy file search - place all tests in quite small top level function, which makes it easy to look at generate C code - avoid exceptions for control flow, instead using simple if-checks and return - simpler code and we don't rely on working exceptions for most code... not that we'd expect exceptions not to work, but it's just unnecessary - overall consolidation of tests and sort into where it makes sense - more tests for bytes in particular This is by no means perfect, but it's a start.
plajjan
force-pushed
the
restruct-builtin-tests
branch
from
df5e25a to
a52cfa6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is by no means perfect, but it's a start.