Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds .NET Standard 2.0 target framework support to the SharpCompress library, expanding platform compatibility. The changes update the project configuration, adjust conditional compilation directives for cryptographic operations, and establish the necessary dependency declarations.
Key Changes:
- Added
netstandard20to the list of target frameworks alongside net48, net8.0, and net10.0 - Updated conditional compilation in
WinzipAesEncryptionData.csto use the appropriate Rfc2898DeriveBytes API for .NET Standard 2.0 - Extended package dependencies to include netstandard2.0 alongside net48 for compatibility packages
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/SharpCompress/SharpCompress.csproj | Added netstandard20 to TargetFrameworks; updated conditional package references to include netstandard20; removed VersionPrefix, AssemblyVersion, and FileVersion properties |
| src/SharpCompress/Common/Zip/WinzipAesEncryptionData.cs | Updated conditional compilation directive to include NETSTANDARD2_0 for password-based key derivation using legacy Rfc2898DeriveBytes constructor |
| src/SharpCompress/packages.lock.json | Added complete dependency tree for .NETStandard,Version=v2.0 framework including required compatibility packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses later comments on #1048
This pull request expands support for the SharpCompress library by adding the
netstandard2.0target framework. The changes ensure compatibility with more .NET platforms, update dependency management, and adjust conditional logic to include the new framework where appropriate.Framework support and compatibility:
netstandard2.0to theTargetFrameworksproperty inSharpCompress.csproj, enabling builds for .NET Standard 2.0.WinzipAesEncryptionData.csto includeNETSTANDARD2_0alongsideNETFRAMEWORKfor password-based key derivation.Dependency management:
SharpCompress.csprojso thatMicrosoft.Bcl.AsyncInterfaces,System.Text.Encoding.CodePages, andSystem.Buffersare included for bothnet48andnetstandard20targets..NETStandard,Version=v2.0inpackages.lock.json, specifying direct and transitive dependencies required for this framework.