Skip to content

Readd netstandard 2.0#1122

Merged
adamhathcock merged 1 commit intomasterfrom
adam/netstandard-20-readd
Jan 8, 2026
Merged

Readd netstandard 2.0#1122
adamhathcock merged 1 commit intomasterfrom
adam/netstandard-20-readd

Conversation

@adamhathcock
Copy link
Owner

addresses later comments on #1048

This pull request expands support for the SharpCompress library by adding the netstandard2.0 target framework. The changes ensure compatibility with more .NET platforms, update dependency management, and adjust conditional logic to include the new framework where appropriate.

Framework support and compatibility:

  • Added netstandard2.0 to the TargetFrameworks property in SharpCompress.csproj, enabling builds for .NET Standard 2.0.
  • Updated conditional logic in WinzipAesEncryptionData.cs to include NETSTANDARD2_0 alongside NETFRAMEWORK for password-based key derivation.

Dependency management:

  • Modified package references in SharpCompress.csproj so that Microsoft.Bcl.AsyncInterfaces, System.Text.Encoding.CodePages, and System.Buffers are included for both net48 and netstandard20 targets.
  • Added a new section for .NETStandard,Version=v2.0 in packages.lock.json, specifying direct and transitive dependencies required for this framework.

Copilot AI review requested due to automatic review settings January 8, 2026 13:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds .NET Standard 2.0 target framework support to the SharpCompress library, expanding platform compatibility. The changes update the project configuration, adjust conditional compilation directives for cryptographic operations, and establish the necessary dependency declarations.

Key Changes:

  • Added netstandard20 to the list of target frameworks alongside net48, net8.0, and net10.0
  • Updated conditional compilation in WinzipAesEncryptionData.cs to use the appropriate Rfc2898DeriveBytes API for .NET Standard 2.0
  • Extended package dependencies to include netstandard2.0 alongside net48 for compatibility packages

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/SharpCompress/SharpCompress.csproj Added netstandard20 to TargetFrameworks; updated conditional package references to include netstandard20; removed VersionPrefix, AssemblyVersion, and FileVersion properties
src/SharpCompress/Common/Zip/WinzipAesEncryptionData.cs Updated conditional compilation directive to include NETSTANDARD2_0 for password-based key derivation using legacy Rfc2898DeriveBytes constructor
src/SharpCompress/packages.lock.json Added complete dependency tree for .NETStandard,Version=v2.0 framework including required compatibility packages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adamhathcock adamhathcock merged commit b6cc95a into master Jan 8, 2026
11 checks passed
@adamhathcock adamhathcock deleted the adam/netstandard-20-readd branch January 8, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant