Skip to content

Fix async test method naming in ZipArchiveAsyncTests #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamhathcock merged 2 commits into from
Jan 12, 2026
Merged

Fix async test method naming in ZipArchiveAsyncTests #1127

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a63653
Initial plan
Copilot Jan 12, 2026
f4b1780
Rename async test methods to use _Async suffix instead of _Sync
Copilot Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/SharpCompress.Test/Zip/ZipArchiveAsyncTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public async ValueTask Zip_Reduce4_ArchiveStreamRead_Async()
}

[Fact]
public async ValueTask Zip_Random_Write_Remove_Sync()
public async ValueTask Zip_Random_Write_Remove_Async()
{
var scratchPath = Path.Combine(SCRATCH_FILES_PATH, "Zip.deflate.mod.zip");
var unmodified = Path.Combine(TEST_ARCHIVES_PATH, "Zip.deflate.noEmptyDirs.zip");
Expand All @@ -141,7 +141,7 @@ public async ValueTask Zip_Random_Write_Remove_Sync()
}

[Fact]
public async ValueTask Zip_Random_Write_Add_Sync()
public async ValueTask Zip_Random_Write_Add_Async()
{
var jpg = Path.Combine(ORIGINAL_FILES_PATH, "jpg", "test.jpg");
var scratchPath = Path.Combine(SCRATCH_FILES_PATH, "Zip.deflate.mod.zip");
Expand Down