Skip to content

Fix Ignoring archive files after processing of internal archive #344

Open
codeFather2 wants to merge 2 commits into
adamhathcock:masterfrom
codeFather2:master
Open

Fix Ignoring archive files after processing of internal archive #344
codeFather2 wants to merge 2 commits into
adamhathcock:masterfrom
codeFather2:master

Conversation

@codeFather2
Copy link
Copy Markdown

Fix #343

Add original folder named OriginalMacOsChild
Add assertion to test (comparison of quantity)
@KvanTTT
Copy link
Copy Markdown

KvanTTT commented Feb 23, 2018

@adamhathcock when are you going to merge this PR?
@codeFather2 could you resolve merge conflicts?

@adamhathcock
Copy link
Copy Markdown
Owner

This is really about non-compressed internal archives which is same as #86 I believe

@codeFather2
Copy link
Copy Markdown
Author

codeFather2 commented May 2, 2018

In this case, the problem was that if there is a file in the child archive, the size of which without compression is longer than the remaining length of the parent archive, then after reading the header of this file, the Reader moved to the end of the parent archive, skipping subsequent files. This is due to the fact that when compressing the file header from the child archive, it was placed before the header of the child archive itself, and then it was duplicated inside. My corrections allowed me to bypass this error, without damage to the usual archives. Without these changes, the files enclosed in the child archive will be uncompressed successfully, but files that follow the child archive will be ignored. The problem was noticed when using the archiver on Mac OS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants