make WriteToDirectory functions use ExtractAllEntries#900
Merged
adamhathcock merged 1 commit intoadamhathcock:masterfrom Mar 3, 2025
Merged
make WriteToDirectory functions use ExtractAllEntries#900adamhathcock merged 1 commit intoadamhathcock:masterfrom
adamhathcock merged 1 commit intoadamhathcock:masterfrom
Conversation
for extracting files from solid archives this can be required to get acceptable extraction performance and should therefore always be called.
adamhathcock
approved these changes
Mar 3, 2025
Owner
|
Thanks. It probably does make sense for this change. I've had my head out of this game for a while so I'm not surprised somethings are done inefficiently. Notes about USAGE should be updated as well. |
This was referenced Aug 1, 2025
This was referenced Nov 24, 2025
This was referenced Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For extracting files from solid archives calling
ExtractAllEntriesis required to get acceptable extraction performance and should therefore always be called.Clearly people are not aware of this function, and the base library not using it is not helping. Perhaps it should be mentioned in the
USAGE.md?