Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new performance testing project to help identify and address memory allocation bottlenecks in SharpCompress. The primary focus is on optimizing RAR decompression through ArrayPool usage and other performance improvements.
Key changes:
- Added new SharpCompress.Performance project with JetBrains profiler integration for CPU and memory analysis
- Implemented ArrayPool-based memory pooling for BitInput and RarVM to reduce allocations
- Optimized RAR unpacking algorithms and LZMA decompression with better resource disposal
- Simplified unsigned right shift operations and improved array operations efficiency
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/SharpCompress.Performance/* | New performance testing project with profiling infrastructure |
| src/SharpCompress/Utility.cs | Simplified unsigned right shift implementations |
| src/SharpCompress/NotNullExtensions.cs | Added aggressive inlining to NotNullOrEmpty method |
| src/SharpCompress/Compressors/Rar/VM/RarVM.cs | Converted to use ArrayPool for memory allocation and improved array operations |
| src/SharpCompress/Compressors/Rar/VM/BitInput.cs | Added IDisposable with ArrayPool-based buffer management |
| src/SharpCompress/Compressors/Rar/UnpackV1/* | Optimized decoding algorithms and cleanup, added proper disposal |
| src/SharpCompress/Compressors/LZMA/* | Added proper disposal of OutWindow resources |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Nov 28, 2025
This was referenced Dec 2, 2025
This was referenced Dec 15, 2025
This was referenced Dec 22, 2025
This was referenced Jan 5, 2026
This was referenced Jan 12, 2026
This was referenced Jan 19, 2026
This was referenced Jan 26, 2026
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got some memory allocation wins with RAR
Pooling for LZMA reading
Testing for more low hanging fruit...