[pull] canary from vercel:canary#2795
Merged
Merged
Conversation
- Questions kept coming up about where `use cache` results actually live, and how static shells, App Shells, and ISR relate - the answers were spread across several pages, but not tied together on the getting-started guide - The runtime prefetching example also implied cookie data needs `allow-runtime`, when the App Shell already carries session data - `allow-runtime` is really about URL data. **Changes** (`docs/app/getting-started/caching`) - Reworked the Usage intro to lead with the cache lifetime concept and hand off to Prerendering - Added a **Where cached content is stored** section: server cache, remote handler, and browser, framed around a cached result being a serialized payload that travels to each. - > if I had time to make it shorter, I would... - We will most likely have a visual aid there and trim it down - Added a static shell ↔ App Shell explanation in Prerendering, and a short Incremental Static Regeneration pointer to the ISR guide - Corrected the runtime prefetching section to the URL-data model (`searchParams`/`params`) - replaced the cookie example with a `/search` one that actually needs `allow-runtime`. - `catchError` (stabilized). - Cross-linked `stale`/`revalidate`/`expire` to `cacheLife` - reviewed and fixed the code-block highlights.
Claude Code keeps trying to pass the `--draft` option to GitHub when I use this stack. However, that option was removed. I've updated this skill to match https://github.com/github/gh-stack/blob/main/skills/gh-stack/SKILL.md using `npx skills`
adamlaska
had a problem deploying
to
preview-builds
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )