windows: restore window position #123
Conversation
appshell/cefclient_win.cpp
Outdated
There was a problem hiding this comment.
This should use the GROUP_NAME and APP_NAME constants defined in config.h instead of hard-coding "Brackets"
There was a problem hiding this comment.
Oh, and PREF_BRACKETS_BASE should be given a more generic name like PREF_APPSHELL_BASE, too.
ghost
assigned
|
Code review changes pushed. |
|
This is for: adobe/brackets#1594 |
appshell/cefclient_win.cpp
Outdated
There was a problem hiding this comment.
the GROUP_NAME macro, if defined, already has a backslash at the end of it (see config.h for edge code). In that case, you'll either need to omit the backslash when copying from pGroup, or omit it here before appending pApp.
There was a problem hiding this comment.
Fixed. I made it so any string passed to this function works with or without a trailing backslash.
|
Initial review complete. |
|
@gruehle Changes pushed. |
|
Looks good. Merging. |
windows: restore window position
windows: restore window position
Glenn submitted a fix for this on Mac, so now we can take this fix for Windows.