This repository was archived by the owner on Sep 2, 2021. It is now read-only.
use g_spawn_command_line_async instead of execlp#319
Merged
Conversation
ghost
assigned
Contributor
|
@ingorichter Hey Ingo, please take a look . |
Member
Author
|
@ingorichter pushed changes. Ready to review. |
Member
Author
|
Also fixes #4909 |
Member
Author
|
Also fixes adobe/brackets#4909 |
ingorichter
added a commit
that referenced
this pull request
Sep 17, 2013
use g_spawn_command_line_async instead of execlp
ingorichter
added a commit
that referenced
this pull request
Dec 8, 2015
use g_spawn_command_line_async instead of execlp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@macie After merging #317 I noticed in the
execlpandexecldocs http://linux.die.net/man/3/execlp...This didn't seem right to replace the
bracketsprocess with the browser. To avoid this, I moved tog_spawn_command_line_asynchttps://developer.gnome.org/glib/2.34/glib-Spawning-Processes.html#g-spawn-command-line-async.While cleaning that up, I also...
CloseLiveBrowserto also kill the same set of browsers google-chrome, chromium, and chromium-browserShowFolderInOSWindowto usefile:urisg_get_user_config_dirinstead of$HOMEto get the correct config folder, see Follow XDG Base Directory Specification brackets#4932