Show full path on Brackets top bar

[bsmaran]

Prerequisites

• Can you reproduce the problem with Debug -> Reload Without Extensions?
• Did you perform a cursory search to see if your bug or enhancement is already reported?
• Did you read the Troubleshooting guide?

For more information on how to write a good bug report read here
For more information on how to contribute read here

Description

I believe it is very useful to show the full path in the top bar so you can realize which source you are editing, thus avoiding undue changes.

Steps to Reproduce

1. [First Step]
2. [Second Step]
3. [and so on...]

Expected behavior: [What you expected to happen]

Actual behavior: [What actually happened]

Versions

Please include the OS and what version of the OS you're running.
Please include the version of Brackets. You can find it under Help -> About Brackets (Windows and Linux) or Brackets -> About Brackets (macOS)

[Matt-Rouse]

As far as I can tell it already does this. Please see the screen shot below, can you provide more info?

[bsmaran]

Please see my screens.
Lubuntu 16.4, Brackets 1.11

[bsmaran]

As you can see, it is missing full path on top bar.

[Matt-Rouse]

Okay, I'll take a look, suggest this needs the "Linux only" tag adding

[petetnt]

It only shows the full path if you are viewing files outside your current project.

I would be +1 on adding this feature under a pref, disabled by default.

The relevant code is here:

https://github.com/adobe/brackets/blob/18dd43112e70acc351804127c8b9a0bebde72062/src/document/DocumentCommandHandlers.js#L188-202

and

https://github.com/adobe/brackets/blob/18dd43112e70acc351804127c8b9a0bebde72062/src/document/DocumentCommandHandlers.js#L227-243

Basic gist would be checking if the give preference is true and shortcircuiting the _shortTitleForDocument function.

[Matt-Rouse]

Brilliant thanks, I'll make a start on this tomorrow and get a Pull Request made.

[Matt-Rouse]

Hi, I have fixed this in the above PR but I have a couple of points to mention.

I've hard coded the menu label, is that okay?
I couldn't see how the _updateTitle method you mentioned actually affected the window title as far as the file path goes as far as I can tell I only need to check the _shortTitleForDocument method, is there a use case I'm missing?
Do I need to add any unit tests for this change.

I look forward to hearing your feedback 👍

[nyteksf]

What is the status on this issue, please? I'd be interested in finishing this one off if still possible. Thanks.

[petetnt]

Hi @nyteksf,

there's some issues with handling the tests on #14005 if you'd want to help with that ^^

[Matt-Rouse]

Hi @nyteksf

Any help with the unit tests would be greatly appreciated! :D