File Rename should complete when clicking anywhere in project panel

[lkcampbell]

OS: Windows 7

Build: sprint 24 development build 0.24.0-0 (master a9e2771)

Repro Steps:

1. Open a project that has a small amount of files. The goal is to have plenty of empty space at the bottom of the project tree.
2. Rename one of the files and, while the edit box is still open, click anywhere on the empty space at the bottom of the project tree.

Observed Result:

Nothing happens. The rename edit box is still around the file name with the cursor blinking.

Expected Result:

The same result that occurs when I click on the working set, the project tree, or even the main editor window: the renaming completes and the rename file box goes away.

[njx]

Reviewed. Marking medium priority and starter bug--seems like it should be straightforward to fix.

[vladnicula]

There are a few ways to fix this. I solved it by calling ProjectManager.forceFinishRename(); when clicking on #sidebar in SidebarView.js htmlReady callback. Another option is to look for the sidebar parent in ProjectManager.js.

I'd like to make a pull request with this. Which approach should I take? :-?

[peterflynn]

@vladnicula I'm a little unclear how the two approaches you're describing differ. Is the difference in which DOM node you listen for clicks on, or just where in the codebase the listener is created?

[vladnicula]

@peterflynn it is the second case. in order to make it work the code needs to bind to #sidebar. The sidebar dom node is stored in SidebarView.js, however from a functionality perspective, this is a behavior that is best added in ProjectManager.js since the rest of the code related to the project tree is there. ProjectManager.js has a dom referece to a child node of the sidebar and uses that for all its binding. So, my question is this : is it ok to add the listener in sidebarview, or in projectmanager? in the second case projectmanager should have a reference to the sidebar node.

[peterflynn]

@vladnicula Any particular reason to care about only clicks in the sidebar? If I click in a blank part of the right-hand toolbar, for example, shouldn't that terminate the rename too? In which case, a capture listener on the overall document might be cleanest. (With logic to ignore clicks within the rename field itself, of course).

[vladnicula]

@peterflynn That's a good point!

So instad of #sidebar it should document or maybe just body - not sure if it will make any difference-. Last question: Where would you add the document.body.addEventListener with ProjectManager.forceFinishRename(); ? I see a lot of files that bind to window.document.body.

[JeffryBooher]

@vladnicula were you still interesting in fixing this issue?

[vladnicula]

@JeffryBooher Yes I am. I know what needs to be added in order to make it work. I'm just not certain where is the best place for it - in which file.

[JeffryBooher]

@vladnicula Hard to tell without knowing how you plan to implement it. I'd say add it to ProjectManager.js and if it looks like something that doesn't belong then it should get pointed out in the code review along with suggestions on where to put it. I think the main thing is to get it working and up for a pull request then let the community guide you on how to make it perfect.

[JeffryBooher]

@vladnicula Do you have time to finish this? We have another issue which we'd like you to add to this.

[vladnicula]

@JeffryBooher I started working on another project. Thanks for the opportunity. Best of luck! 👍

[lkcampbell]

@vladnicula, to clarify, are you no longer working on this bug? If that is the case, I can take it over.

@JeffryBooher, I can look at the other bug as well. Are you referring to issue #4693 or a different issue?