This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Changes to send data only once per 24 hours#14695
Merged
shubhsnov merged 2 commits intoadobe:masterfrom Apr 12, 2019
niteskum:snchit_fix_for_send_event_every_24_hours
Merged
Changes to send data only once per 24 hours#14695shubhsnov merged 2 commits intoadobe:masterfrom niteskum:snchit_fix_for_send_event_every_24_hours
shubhsnov merged 2 commits intoadobe:masterfrom
niteskum:snchit_fix_for_send_event_every_24_hours
Conversation
Contributor
Author
|
@niteskum @shubhsnov @swmitra @narayani28 please review changes. |
Collaborator
|
Hey @SnchitGrover Can you go ahead and get yourself added to the Adobe org as mentioned here. The CLA check won't pass until you do that. One you get added, close and reopen the pull request. |
shubhsnov
reviewed
Apr 12, 2019
shubhsnov
approved these changes
Apr 12, 2019
Collaborator
|
Since we're going ahead with non-persistent data, this looks okay to me. LGTM 👍 |
Collaborator
|
@SnchitGrover pull in the laster master once and do a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic to log events only once per (24 hours or session), whatever comes first