Improvements to the Inline Editor Tests

[TomMalbran]

This commit basically joins all the htmlToCSSProvider tests inside the Inline Editor Tests into the same window. These are lots of tests where each used a single window, so this makes it faster and nicer to test. There are 3 test left that check for the Inline editor priority were each use their own window since I wasn't sure how to best change those test to be handled inside the same window. But anyway the testing is a lot nicer.

This branch is based on #4581, so is best to merge that one first.

[jasonsanjose]

@TomMalbran I'm seeing a failure in should close inline editor when file deleted on disk. Can you reproduce?

[TomMalbran]

@jasonsanjose Yes, I was able to reproduce it, but it got fixed with the use of runs when closing all the files, where using just 1 runs worked, but using 2 didn't.

[jasonsanjose]

@TomMalbran I merged #4581. Can you update this branch to fix the conflicts? Thanks!

[TomMalbran]

@jasonsanjose PR updated.

I was still able to get should close inline editor when file deleted on disk failures. Usually on the first run, but not always, and worked on a rerun. I still always get should delete the temp directory errors, but I had them before this change and I had the same error when deleting folders.

[TomMalbran]

This could be replaced with Dialogs.cancelModalDialogIfOpen if it could receive an additional and optional button ID parameter.

[jasonsanjose]

Ok. Given the state of or build machine (integration tests run out of memory), I'd rather take this fix and the new failures and address those failures separately.